EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39848 )
Change subject: mb/google/deltaur: Update onboard memory config
......................................................................
Patch Set 21:
(4 comments)
https://review.coreboot.org/c/coreboot/+/39848/21/src/mainboard/google/delta...
File src/mainboard/google/deltaur/romstage.c:
https://review.coreboot.org/c/coreboot/+/39848/21/src/mainboard/google/delta...
PS21, Line 14:
nits: remove one line.
https://review.coreboot.org/c/coreboot/+/39848/21/src/mainboard/google/delta...
File src/mainboard/google/deltaur/variants/deltan/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/39848/21/src/mainboard/google/delta...
PS21, Line 9:
nits:remove the warp line. or add warp line in another makefile.
https://review.coreboot.org/c/coreboot/+/39848/21/src/mainboard/google/delta...
File src/mainboard/google/deltaur/variants/deltan/memory.c:
https://review.coreboot.org/c/coreboot/+/39848/21/src/mainboard/google/delta...
PS21, Line 13:
nit: remove one line.
https://review.coreboot.org/c/coreboot/+/39848/21/src/mainboard/google/delta...
PS21, Line 43:
nit:remove this line.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39848
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I29059f09dd08c81b5ca5fe1215f33871835703fe
Gerrit-Change-Number: 39848
Gerrit-PatchSet: 21
Gerrit-Owner: Varun Joshi
varun.joshi@intel.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kevin Chowski
chowski@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Varun Joshi
varun.joshi@intel.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anil Kumar K
anil.kumar.k@intel.corp-partner.google.com
Gerrit-CC: Bernardo Perez Priego
bernardo.perez.priego@intel.corp-partner.google.com
Gerrit-CC: Bora Guvendik
bora.guvendik@intel.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Selma Bensaid
selma.bensaid@intel.corp-partner.google.com
Gerrit-Comment-Date: Tue, 31 Mar 2020 04:17:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment