Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40643 )
Change subject: soc/baytrail/raminit: Populate SMBIOS type 17 tables ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/40643/1/src/soc/intel/baytrail/roms... File src/soc/intel/baytrail/romstage/raminit.c:
https://review.coreboot.org/c/coreboot/+/40643/1/src/soc/intel/baytrail/roms... PS1, Line 66: /* copy raw data into spd struct */ Why do all the comments start in lowercase?
https://review.coreboot.org/c/coreboot/+/40643/1/src/soc/intel/baytrail/roms... PS1, Line 67: memcpy(&spd, dram_data, SPD_PAGE_LEN); Why the memcpy? spd_decode_ddr3 does not modify the buffer (granted, the parameter should be const). Also, if the buffer pointed by `dram_data` isn't big enough it's going to run astray anyway.