Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38541 )
Change subject: ec/google/chromeec: Add SSDT generator for ChromeOS EC ......................................................................
Patch Set 3:
(5 comments)
https://review.coreboot.org/c/coreboot/+/38541/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38541/3//COMMIT_MSG@9 PS3, Line 9: Newer versions of the Linux kernel would like to consume information Since what version exactly?
https://review.coreboot.org/c/coreboot/+/38541/3//COMMIT_MSG@14 PS3, Line 14: was is
https://review.coreboot.org/c/coreboot/+/38541/3/src/ec/google/chromeec/ec.h File src/ec/google/chromeec/ec.h:
https://review.coreboot.org/c/coreboot/+/38541/3/src/ec/google/chromeec/ec.h... PS3, Line 328: /** /*
https://review.coreboot.org/c/coreboot/+/38541/3/src/ec/google/chromeec/ec.c File src/ec/google/chromeec/ec.c:
https://review.coreboot.org/c/coreboot/+/38541/3/src/ec/google/chromeec/ec.c... PS3, Line 1721: Tab?
https://review.coreboot.org/c/coreboot/+/38541/3/src/ec/google/chromeec/ec_l... File src/ec/google/chromeec/ec_lpc.c:
https://review.coreboot.org/c/coreboot/+/38541/3/src/ec/google/chromeec/ec_l... PS3, Line 467: CHIP_NAME("Google Chrome EC") Did you change the name to ChromeOS EC?