Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45407 )
Change subject: region_file_update_data: Change API to accept array of structs
......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45407/2/src/drivers/mrc_cache/mrc_c...
File src/drivers/mrc_cache/mrc_cache.c:
https://review.coreboot.org/c/coreboot/+/45407/2/src/drivers/mrc_cache/mrc_c...
PS2, Line 422: struct update_region_file_entry entries[1];
You should be able to just declare this as `struct update_region_file_entry entry` (for example), an […]
Done
https://review.coreboot.org/c/coreboot/+/45407/2/src/drivers/mrc_cache/mrc_c...
PS2, Line 551: struct update_region_file_entry entries[1];
same here
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45407
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia530f7d428b9b07ce3a73e348016038d9daf4c15
Gerrit-Change-Number: 45407
Gerrit-PatchSet: 3
Gerrit-Owner: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Tue, 15 Sep 2020 18:06:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment