[coreboot-gerrit] Change in coreboot[master]: memranges: Change align attribute to be log2 of required alignment

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39810 )

Change subject: memranges: Change align attribute to be log2 of required alignment
......................................................................

Patch Set 7:

(3 comments)

https://review.coreboot.org/c/coreboot/+/39810/2/src/include/memrange.h 
File src/include/memrange.h:

https://review.coreboot.org/c/coreboot/+/39810/2/src/include/memrange.h@29 
PS2, Line 29: 	size_t align;
> Valid point. I think it makes sense to switch to unsigned char.

Done

https://review.coreboot.org/c/coreboot/+/39810/2/src/include/memrange.h@116 
PS2, Line 116: log2(4 * KiB)
> It isn't immediately obvious, though. […]

Done

https://review.coreboot.org/c/coreboot/+/39810/5/src/lib/memrange.c 
File src/lib/memrange.c:

https://review.coreboot.org/c/coreboot/+/39810/5/src/lib/memrange.c@236 
PS5, Line 236: 1ULL << ranges->align
> Worth adding a helper that spits this out instead of open coding?

Done