build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29968 )
Change subject: qcs405: Add blsp spi driver and enable SPI-NOR ......................................................................
Patch Set 6:
(6 comments)
https://review.coreboot.org/#/c/29968/6/src/soc/qualcomm/qcs405/spi.c File src/soc/qualcomm/qcs405/spi.c:
https://review.coreboot.org/#/c/29968/6/src/soc/qualcomm/qcs405/spi.c@311 PS6, Line 311: gpio_configure(GPIO(26), 3, GPIO_NO_PULL, GPIO_16MA, GPIO_INPUT); line over 80 characters
https://review.coreboot.org/#/c/29968/6/src/soc/qualcomm/qcs405/spi.c@312 PS6, Line 312: gpio_configure(GPIO(27), 3, GPIO_NO_PULL, GPIO_16MA, GPIO_INPUT); line over 80 characters
https://review.coreboot.org/#/c/29968/6/src/soc/qualcomm/qcs405/spi.c@313 PS6, Line 313: gpio_configure(GPIO(28), 4, GPIO_PULL_UP, GPIO_16MA, GPIO_INPUT); line over 80 characters
https://review.coreboot.org/#/c/29968/6/src/soc/qualcomm/qcs405/spi.c@314 PS6, Line 314: gpio_configure(GPIO(29), 4, GPIO_NO_PULL, GPIO_16MA, GPIO_INPUT); line over 80 characters
https://review.coreboot.org/#/c/29968/6/src/soc/qualcomm/qcs405/spi.c@708 PS6, Line 708: struct spi_op vectors[], size_t count) code indent should use tabs where possible
https://review.coreboot.org/#/c/29968/6/src/soc/qualcomm/qcs405/spi.c@708 PS6, Line 708: struct spi_op vectors[], size_t count) please, no spaces at the start of a line