Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38289 )
Change subject: xcompile: Disable null pointer optimizations
......................................................................
Patch Set 2:
Patch Set 1: Code-Review-1
Please keep the optimisations enabled where they have not been proven to cause problems.
AFAIR removing strict-aliasing creates poor code around MMIO write operations.
Alright, I've only disabled the null pointer optimization. coreinfo still seems to work with the other optimizations enabled, but I think more testing should still be done (perhaps LTO should be labeled as experimental for now).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38289
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4492277f02418ade3fe7a75304e8e0611f49ef36
Gerrit-Change-Number: 38289
Gerrit-PatchSet: 2
Gerrit-Owner: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 11 Jan 2020 18:57:59 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment