Attention is currently required from: Furquan Shaikh, Mathew King, Bhanu Prakash Maiya, EricR Lai.
Ivy Jian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52181 )
Change subject: mb/google/guybrush/var/guybrush: Add FPMCU configration
......................................................................
Patch Set 7:
(2 comments)
File src/mainboard/google/guybrush/variants/guybrush/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/52181/comment/624bfcbb_0c603c4a
PS4, Line 101:
Use tabs instead of spaces here and in the below lines.
done
File src/mainboard/google/guybrush/variants/guybrush/variant.c:
https://review.coreboot.org/c/coreboot/+/52181/comment/67150d80_1a3b0711
PS4, Line 8: variant_fpmcu_init
I think we can just use the has_power_resource since uart/acpi already support it. […]
Thanks Furquan and Eric for reminder.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52181
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7c56b0db193be6804d07c2f333445c2a1dbf9f59
Gerrit-Change-Number: 52181
Gerrit-PatchSet: 7
Gerrit-Owner: Ivy Jian
ivy_jian@compal.corp-partner.google.com
Gerrit-Reviewer: Bhanu Prakash Maiya
bhanumaiya@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Mathew King
mathewk@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Mathew King
mathewk@chromium.org
Gerrit-Attention: Bhanu Prakash Maiya
bhanumaiya@google.com
Gerrit-Attention: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Comment-Date: Thu, 08 Apr 2021 08:48:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-MessageType: comment