Shaunak Saha has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45052 )
Change subject: soc/intel/tigerlake: Add Acoustic features ......................................................................
Patch Set 10:
(6 comments)
https://review.coreboot.org/c/coreboot/+/45052/9//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45052/9//COMMIT_MSG@11 PS9, Line 11: AcousticNoiseMitigation : FastPkgCRampDisable : SlowSlewRateFor
Can this be formatted as a list, e.g., […]
Done
https://review.coreboot.org/c/coreboot/+/45052/9//COMMIT_MSG@14 PS9, Line 14: AcousticNoiseMitigation is the UPD for Acoustic Noise Mitigation. : FastPkgCRampDisable UPD's are to disable Fast Slew Rate for Deep Package : C States for VR domains. : SlowSlewRate UPD's are the Slew Rate configuration for Deep Package C : States for VR domains. Slew rates are fast time divided by 2.
This is already in the comments, I don't think it's required here
Done
https://review.coreboot.org/c/coreboot/+/45052/9/src/soc/intel/tigerlake/fsp... File src/soc/intel/tigerlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/45052/9/src/soc/intel/tigerlake/fsp... PS9, Line 261: sizeof(uint8_t)
May be better to be more explicit here: sizeof(config->SlowSlewRate[0])
Done
https://review.coreboot.org/c/coreboot/+/45052/9/src/soc/intel/tigerlake/fsp... PS9, Line 261: *
nit: spaces around operators please
Done
https://review.coreboot.org/c/coreboot/+/45052/9/src/soc/intel/tigerlake/fsp... PS9, Line 264: sizeof(uint8_t)
May be better to be more explicit here: sizeof(config->FastPkgCRampDisable[0])
Done
https://review.coreboot.org/c/coreboot/+/45052/9/src/soc/intel/tigerlake/fsp... PS9, Line 264: *
nit: spaces around operators please
Done