Attention is currently required from: Anand Vaikar, Paul Menzel.
Ana Carolina Cabral has posted comments on this change by Ana Carolina Cabral. ( https://review.coreboot.org/c/coreboot/+/84776?usp=email )
Change subject: drivers/amd/nova: Add Nova Card common driver ......................................................................
Patch Set 7:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84776/comment/861e87c5_1d208539?usp... : PS5, Line 7: directory
As you add more than the directory, maybe just write “common driver”?
Done
https://review.coreboot.org/c/coreboot/+/84776/comment/00014807_f2dbd1a4?usp... : PS5, Line 9: As multiple boards use the NOVA daughter card, the function that detects : the connector type has been moved to the drivers folder and : will be refactored in the soc path in the following patches.
This looks a little strange. Maybe also re-flow the second and third line.
Done
File src/drivers/amd/nova/Kconfig:
https://review.coreboot.org/c/coreboot/+/84776/comment/6495ef10_4c60e0cd?usp... : PS5, Line 4: def_bool n
will this be enabled via defconfig?
It can be, I wasn`t sure if all mainboards have a nova card
File src/drivers/amd/nova/nova_card.c:
https://review.coreboot.org/c/coreboot/+/84776/comment/d815d4fc_6fdfd515?usp... : PS5, Line 24: uint16_t connector_type = data[1] | data[0] << 8;
`please, no spaces at the start of a line` […]
Done