Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42894 )
Change subject: soc/amd/common: Redo ACPIMMIO_BASE and _BANK
......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42894/8/src/soc/amd/common/block/in...
File src/soc/amd/common/block/include/amdblocks/acpimmio_map.h:
https://review.coreboot.org/c/coreboot/+/42894/8/src/soc/amd/common/block/in...
PS8, Line 97: #ifdef __ACPI__
ah, ok, that's probably a good thing then
A bit more background; all addresses here represent the x86-centric view of the memory map and should have ENV_X86 guard. CB:42523
Seems like I got tired of waiting for a developer to submit the works and after sitting with +2's for two weeks I finally had abandoned these.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42894
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I31f2d04d9fc8bdd9e270fb3cb48d71f215999a50
Gerrit-Change-Number: 42894
Gerrit-PatchSet: 8
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 11 Dec 2020 16:20:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment