Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30942 )
Change subject: mainboard/samsung/350v5c: add initial board files and Kconfig option for 6 MB flash ......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/#/c/30942/7/src/mainboard/Kconfig File src/mainboard/Kconfig:
https://review.coreboot.org/#/c/30942/7/src/mainboard/Kconfig@27 PS7, Line 27: config BOARD_ROMSIZE_KB_6144 : bool
I would mention this in the commit message.
I think all the changes to this file should be a separate commit.
I'd really question why we need this though. As far as I know, there's no 6MB rom chip.
If it's only using 6MB of an 8MB part, the CBFS size should be adjusted, we don't need a 6MB ROM. If it's 2 physical ROM chips, a 2MB and a 4MB, one for the ME and one for the BIOS, just use the size for the BIOS ROM chip, and ignore the ME in the coreboot build.