Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30942 ) Change subject: mainboard/samsung/350v5c: add initial board files and Kconfig option for 6 MB flash ...................................................................... Patch Set 8: (1 comment) https://review.coreboot.org/#/c/30942/7/src/mainboard/Kconfig File src/mainboard/Kconfig: https://review.coreboot.org/#/c/30942/7/src/mainboard/Kconfig@27 PS7, Line 27: config BOARD_ROMSIZE_KB_6144 : bool
I would mention this in the commit message. I think all the changes to this file should be a separate commit.
I'd really question why we need this though. As far as I know, there's no 6MB rom chip. If it's only using 6MB of an 8MB part, the CBFS size should be adjusted, we don't need a 6MB ROM. If it's 2 physical ROM chips, a 2MB and a 4MB, one for the ME and one for the BIOS, just use the size for the BIOS ROM chip, and ignore the ME in the coreboot build. -- To view, visit https://review.coreboot.org/c/coreboot/+/30942 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I64fcf931938fb3b158b9576b787f452bf6077843 Gerrit-Change-Number: 30942 Gerrit-PatchSet: 8 Gerrit-Owner: Kacper Słomiński <kacper.slominski72@gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Kacper Słomiński <kacper.slominski72@gmail.com> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Thu, 17 Jan 2019 19:37:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com> Gerrit-MessageType: comment