Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43418 )
Change subject: soc/amd/picasso: use FADT devicetree configuration options ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/43418/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43418/1//COMMIT_MSG@7 PS1, Line 7: soc/amd/picasso: use FADT devicetree configuration options
Would be great to also read, that the defaults are changed. (I f I am not mistaken. […]
Done
https://review.coreboot.org/c/coreboot/+/43418/1//COMMIT_MSG@19 PS1, Line 19: The fadt_pm_profile option is removed from this patch. See commit : 56da63c3dc3f50cfac541c779b608e1bae9e635c which removed overriding that : field.
I found a bug in CB:1055 where the SHA in gerrit doesn't match the SHA in the actual git repo. […]
I tried to clarify the last paragraph in more recent versions of the commit message