23 Aug
2020
23 Aug
'20
6:49 p.m.
Samuel Holland has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44695 )
Change subject: superio/winbond/wpcd376i: Resurrect the driver ......................................................................
Patch Set 1:
Patch Set 1: Code-Review+1
Are you planning to add things to the chip.h file? If not, I'd drop that one, since it's currently basically empty. Not too opposed to keeping it though. The rest looks good to me, but wanted to check back about the chip.h file before giving it a +2
No. I don't have any documentation for this chip, and the driver works "as is", so I don't plan to make any more changes. I thought the chip.h file might have been required. I will remove it.
--
To view, visit https://review.coreboot.org/c/coreboot/+/44695
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0ff1a63c47d5dff2599c83a1cebe1ac5ff2136b1
Gerrit-Change-Number: 44695
Gerrit-PatchSet: 1
Gerrit-Owner: Samuel Holland samuel@sholland.org
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 23 Aug 2020 16:49:18 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment