[coreboot-gerrit] Change in coreboot[master]: soc/intel/skylake: Add romstage common stage file

[Patrick Rudolph (Code Review)]

Attention is currently required from: Bernardo Perez Priego.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42213 )

Change subject: soc/intel/skylake: Add romstage common stage file
......................................................................


Patch Set 3:

(1 comment)

File src/soc/intel/skylake/romstage/romstage.c:

https://review.coreboot.org/c/coreboot/+/42213/comment/f33cd74a_34a52e63 
PS3, Line 42: romstage_cmn_pch_init
if this function is common, there's no need to call it from here. If it's not shared between all SoC, why is it in common then?



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/42213
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I31dc5baca23c3d339fbe5fb06b8049789d9ba415
Gerrit-Change-Number: 42213
Gerrit-PatchSet: 3
Gerrit-Owner: Bernardo Perez Priego <[e-mail]>
Gerrit-Reviewer: Bora Guvendik <[e-mail]>
Gerrit-Reviewer: Martin Roth <[e-mail]>
Gerrit-Reviewer: Patrick Georgi <[e-mail]>
Gerrit-Reviewer: Patrick Rudolph <[e-mail]>
Gerrit-Reviewer: Selma Bensaid <[e-mail]>
Gerrit-Reviewer: Subrata Banik <[e-mail]>
Gerrit-Reviewer: Usha P <[e-mail]>
Gerrit-Reviewer: Varun Joshi <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Patrick Rudolph <[e-mail]>
Gerrit-CC: Paul Menzel <[e-mail]>
Gerrit-Attention: Bernardo Perez Priego <[e-mail]>
Gerrit-Comment-Date: Wed, 03 Feb 2021 12:04:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment