Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41876 )
Change subject: soc/intel/jasperlake: Generate LP4x SPD files using gen_spd.go ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41876/4/src/soc/intel/jasperlake/sp... File src/soc/intel/jasperlake/spd/lp4x/spd-1.hex:
https://review.coreboot.org/c/coreboot/+/41876/4/src/soc/intel/jasperlake/sp... PS4, Line 21: 00 00 00 00 00 00 00 : 00 00 00 00 00 00 00 00 00 00 00 00 00
These bytes(Module Part number) along with byte 325(Module serial number) are encoded as ASCII blank […]
JEDEC spec says that bytes 149-15C should be 0x20 for unused digits. I left it as blank since MRC doesn't really care about it. If you think having blank might be better, I can update the tool to replace these bytes with 0x20.