Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37322 )
Change subject: mb/google/hatch/akemi: Set touchpad data hold time more than 300ns
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37322/2/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/variants/akemi/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/37322/2/src/mainboard/google/hatch/...
PS2, Line 60: 400
Does 310 or 325 not meet vendor requirement?
No, 310 or 325 also meet requirement, vendor requirement 0.3us <= x <= 0.9us. If use default, real measure result rough equal 0.29us. So do this modification.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37322
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I75e33419cbaef746487de6ee8628d07cf08adaa9
Gerrit-Change-Number: 37322
Gerrit-PatchSet: 2
Gerrit-Owner: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Philip Chen
philipchen@google.com
Gerrit-Comment-Date: Thu, 19 Dec 2019 01:26:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Comment-In-Reply-To: Philip Chen
philipchen@google.com
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment