Eric Peers has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45987 )
Change subject: amd/picasso/verstage: replace rsa accel with modexp ......................................................................
Patch Set 4: Code-Review+1
(2 comments)
what devices did you test this with? I'm assuming no perf penalty on dalboz, nor on picasso?
https://review.coreboot.org/c/coreboot/+/45987/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45987/4//COMMIT_MSG@12 PS4, Line 12: acclerating only calculation part(modexp) increases transparency nit accelerating
https://review.coreboot.org/c/coreboot/+/45987/4/src/soc/amd/picasso/psp_ver... File src/soc/amd/picasso/psp_verstage/vboot_crypto.c:
https://review.coreboot.org/c/coreboot/+/45987/4/src/soc/amd/picasso/psp_ver... PS4, Line 132: sig_swapped[i] = swab32(inout_32[key->arrsize - i - 1]); I'm guessing the answer is no, but is there a way to do this (probably a different svc call?) without swapping the bytes and then swapping them back?