Francois Toguo Fotso has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32090 )
Change subject: smbios: Add and adapt fields for 32 bits SMBIOS to version 3.2
......................................................................
Patch Set 11:
(3 comments)
Patch Set 9:
(2 comments)
Paul,
Your comment have been implemented.
"No builds executed", most likely because no code change was required.
Regards,
Francois
https://review.coreboot.org/#/c/32090/9//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/32090/9//COMMIT_MSG@10
PS9, Line 10: smbio_entry
smbio*s*?
Done
https://review.coreboot.org/#/c/32090/9/src/arch/x86/smbios.c
File src/arch/x86/smbios.c:
https://review.coreboot.org/#/c/32090/9/src/arch/x86/smbios.c@815
PS9, Line 815:
Please do not mix format changes in functional commits.
Done
https://review.coreboot.org/#/c/32090/6/src/include/smbios.h
File src/include/smbios.h:
https://review.coreboot.org/#/c/32090/6/src/include/smbios.h@466
PS6, Line 466: smbios_type17 {
do src/include/memory_info. […]
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32090
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1171c20ac85a2231d949d4ac1c3e3c544ba3e5ef
Gerrit-Change-Number: 32090
Gerrit-PatchSet: 11
Gerrit-Owner: Francois Toguo Fotso
francois.toguo.fotso@intel.com
Gerrit-Reviewer: Francois Toguo Fotso
francois.toguo.fotso@intel.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Francois Toguo Fotso
francois.toguo.fotso@intel.corp-partner.google.com
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-CC: Lijian Zhao
lijian.zhao@intel.com
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Comment-Date: Tue, 02 Apr 2019 17:18:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: HAOUAS Elyes
ehaouas@noos.fr
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment