Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47296 )
Change subject: soc/intel/xeon_sp: Use a common function to get the IIO HOB
......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/47296/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/47296/1//COMMIT_MSG@7
PS1, Line 7: nb
soc
Done
https://review.coreboot.org/c/coreboot/+/47296/1/src/soc/intel/xeon_sp/skx/s...
File src/soc/intel/xeon_sp/skx/soc_util.c:
https://review.coreboot.org/c/coreboot/+/47296/1/src/soc/intel/xeon_sp/skx/s...
PS1, Line 298: hob = fsp_find_extension_hob_by_guid(
: fsp_hob_iio_universal_data_guid, &hob_size);
: assert(hob != NULL && hob_size != 0);
:
Missed this one.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47296
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I69f336c1ff348b8e820340b84494929f2c58ce72
Gerrit-Change-Number: 47296
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 09 Nov 2020 09:46:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Marc Jones
marc@marcjonesconsulting.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment