Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33623 )
Change subject: superio/fintek: Add f81803a
......................................................................
Patch Set 6:
I could have created something devicetree based, but the structure would have to be too complicated due to all the parameters that needs to be controlled. I thought that an API breaking the parameters into logically grouped parameters was much easier to understand and program.
Yep
As I mentioned before, I can't merge Padmelon board until 33615 is merged. Locally, I have build and tested the SIO code... found 1 mistake (caused by trying to enable HWM too early of all things, lol). Once I moved enabling HWM to early ramstage (just before calling the API), it worked as expected.
I know; just wanted to let you know why I haven't +2ed the patch yet, but that I'm happy with its current state
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33623
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3d336e76bccc38452b1b1aefef5d4a4f7ee129a8
Gerrit-Change-Number: 33623
Gerrit-PatchSet: 6
Gerrit-Owner: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Charles Marslett
charles.marslett@silverbackltd.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 02 Jul 2019 13:51:21 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment