[coreboot-gerrit] Change in coreboot[master]: lib/spd: Demote log about using default DDR4 params to NOTICE

[Reka Norman (Code Review)]

Attention is currently required from: Paul Menzel, Tim Wawrzynczak, Ivy Jian, Julius Werner, Eric Lai.
Reka Norman has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63774 )

Change subject: lib/spd: Demote log about using default DDR4 params to NOTICE
......................................................................

Patch Set 5:

(1 comment)

Patchset:

PS1:
> Done

Sorry, I feel like this is my fault. There's a bug assigned to me to check whether the DDR4 values are still correct for LPDDR5 (http://b/223341399). I just haven't gotten around to it and I've been out for the last two weeks so I didn't see this thread.

I see that CB:63680 already added a case for LPDDR5, treating it the same as DDR4, but I still want to go through and double check this is correct. I'll get on to it soon.

As for this CL, I completely agree with Julius that it's good to have a test to alert us that the memory type is unsupported and force us to go through and check that the values are still correct for the new memory type. I don't have a strong opinion on exactly what the log level should be, e.g. I see your point that people should still be paying attention to warnings. But I think we should make sure it's still caught by the test. I'm not familiar with what this test does. Does it just check there are no ERROR messages in the coreboot log?