Bill XIE has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41390 )
Change subject: mb/lenovo/x230: Fix issues detected after 6b95507e is merged ......................................................................
Patch Set 11:
Patch Set 11: Code-Review-1
(1 comment)
The content LGTM. Can you split the commit up into multiple commits?
- docs: fix typo
- x230s: disable unconnected ports
- x230/x230s: disable superseed capabilities for usb port 3 - there are no RXP/TXP lines (one line dts change)
- x230/x230s: reorganisze baseboard & overrides devices (all remaining dts changes, since this is a no-op)
- x230s: clean up early_init as similiar to x230.
I can only accept to split "disabling superspeed capabilities" stuff into a separate commit. It is not my fault that my commit trying to introducing x230s (CB:41168) got merged semi-finished.
I would rather completely revert CB:41168 and commit it again in a more elegant way, with "disabling superspeed capabilities" splitted out, as you wish.