Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41595 )
Change subject: AGESA f14/f15tn/f16kb: Factor out PCI MMIO base/size
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41595/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/41595/4//COMMIT_MSG@10
PS4, Line 10: We set them as fallback
: so that we can override the settings using BLDCFG options if desired.
I think it has to be in sync with the Kconfig options so removing that override possibility seems like a good idea.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41595
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7244c39d2c2aa02a3a9092ddae98e4ac9da89107
Gerrit-Change-Number: 41595
Gerrit-PatchSet: 4
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Mike Banon
mikebdp2@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 23 May 2020 07:47:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment