Attention is currently required from: Subrata Banik.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59509 )
Change subject: soc/intel/common/thermal: Refactor thermal block to improve reusability
......................................................................
Patch Set 8:
(2 comments)
Patchset:
PS8:
oh, actually I wanted to comment on CB:59209
File src/soc/intel/common/block/thermal/thermal_pmc.c:
https://review.coreboot.org/c/coreboot/+/59509/comment/c9c25453_4105363f
PS8, Line 42: .offset = PMC_PWRM_THERMAL_PHLC,
: .value = PMC_PWRM_THERMAL_PHLC_PHLCLOCK,
: },
: {
: .offset = PMC_PWRM_THERMAL_TLEN,
: .value = PMC_PWRM_THERMAL_TLEN_TLENLOCK,
:
set by FSP unconditionally
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59509
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I14df5145629ef03f358b98e824bca6a5b8ebdfc6
Gerrit-Change-Number: 59509
Gerrit-PatchSet: 8
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Michael Niewöhner
foss@mniewoehner.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Subrata Banik
subi.banik@gmail.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Comment-Date: Sun, 06 Mar 2022 19:11:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment