Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41471 )
Change subject: soc/intel/broadwell: Mask lower 20 bits of TOLUD and TOLM in systemagent.asl
......................................................................
Patch Set 6:
Patch Set 6:
Patch Set 6:
Why was this not fixed in the whole tree?
Was any platform missed? I had done a grep for TLUD in *.asl files:
Um, yes, `git grep TLUD reveals them. :)
Were there more platforms that required changes?
Haswell (which is most likely exactly the same as Broadwell
in separate dirs) and Sandy Bridge at least.
I would like to have some conclusion about the ME range,
though, before we continue. Should we drop that? It seems
safe enough, to me...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41471
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I11b3ef8deda21930998471ab6e712da4c62f5b02
Gerrit-Change-Number: 41471
Gerrit-PatchSet: 6
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 01 Jun 2020 20:41:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment