Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40424 )
Change subject: ec/google/chromeec: Add support for USB Type-C alternate mode control ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40424/2/src/ec/google/chromeec/acpi... File src/ec/google/chromeec/acpi/cros_ec.asl:
https://review.coreboot.org/c/coreboot/+/40424/2/src/ec/google/chromeec/acpi... PS2, Line 71: Name (_ADR, 0) : Name (_DSD, Package () { : ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), : Package() { : Package () { "usb-role-switch", : _SB.PCI0.PMC.MUX.CON0 }, : Package () { "mode-switch", : _SB.PCI0.PMC.MUX.CON0 }, : Package () { "orientation-switch", : _SB.PCI0.PMC.MUX.CON0 }, : Package () { "power-role", "dual" }, : Package () { "data-role", "dual" }, : } : }) :
Please check with twawrzynczak@. […]
John, the patch I've got in flight that enables auto-generation of those properties is CB:40618. Could you rebase on top of that? It will probably depend on having the PMC MUX driver set up in the SSDT as well, so it can be found in the devicetree.