[coreboot-gerrit] Change in ...coreboot[master]: nb/intel/nehalem: Die if no memory ranks found

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33403 )

Change subject: nb/intel/nehalem: Die if no memory ranks found
......................................................................

Patch Set 1: Code-Review+2

(1 comment)
> Patch Set 1:
> > Patch Set 1: Code-Review-1
> >
> > This would break coreboot when only the second channel is populated.
>
> The iteration of the loop is skipped if the channel isn't populated (see the check on line 923), so I don't think(?) that would happen.

Yeah, I think that would do it. Think.

https://review.coreboot.org/#/c/33403/1/src/northbridge/intel/nehalem/ramini... 
File src/northbridge/intel/nehalem/raminit.c:

https://review.coreboot.org/#/c/33403/1/src/northbridge/intel/nehalem/ramini... 
PS1, Line 923: 		if (!info->populated_ranks_mask[channel])
             : 			continue;
Ah, there's this thing already