Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42712 )
Change subject: security/intel/txt: Add Intel TXT support ......................................................................
Patch Set 6:
Patch Set 4: Code-Review-1
Mark at "-1" as some more work is needed.
Hi Jonathan,
Looks like I messed up the assembly part of the change... Sorry for the inconvenience, the latest patchset should work. I've also made CB:44183 to fix the same problem on master. I was able to reproduce the problem on a Haswell board and saw the hang is actually an exception:
CPU Index 0 - APIC 0 Unexpected Exception:13 @ 10:7f781080 - Halting Code: 0 eflags: 00010006 cr2: 00000000 eax: 0000000a ebx: 00000000 ecx: 03020100 edx: 00000000 edi: 7f7c4f10 esi: ffe40000 ebp: 7f7c4ee8 esp: 7f7c4e600x7f781040: 00 0f 32 50 52 b9 6a 02 0x7f781048: 00 00 0f 32 50 52 b9 6b 0x7f781050: 02 00 00 0f 32 50 52 b9 0x7f781058: 6c 02 00 00 0f 32 50 52 0x7f781060: b9 6e 02 00 00 0f 32 50 0x7f781068: 52 b9 6f 02 00 00 0f 32 0x7f781070: 50 52 31 db eb 14 89 d9 0x7f781078: d1 e1 03 0d 00 02 00 00 0x7f781080: 0f 32 50 52 41 0f 32 50 0x7f781088: 52 43 b9 fe 00 00 00 0f 0x7f781090: 32 25 ff 00 00 00 39 d8 0x7f781098: 7d dc 0f 20 c0 0d 00 00 0x7f7810a0: 00 60 0f 22 c0 b9 ff 02 0x7f7810a8: 00 00 0f 32 25 ff fb ff 0x7f7810b0: ff 0f 30 b9 50 02 00 00 0x7f7810b8: 31 d2 31 c0 0f 30 b9 58 0x7f7c4edc: 0x0027b68e 0x7f7c4ed8: 0x00000003 0x7f7c4ed4: 0x7f7c4ee8 0x7f7c4ed0: 0x7f7c4ee8 0x7f7c4ecc: 0xffe40000 0x7f7c4ec8: 0x7f7c4f10 0x7f7c4ec4: 0x00000011 0x7f7c4ec0: 0x00004200 0x7f7c4ebc: 0x00000003 0x7f7c4eb8: 0x7f7c4ed8 0x7f7c4eb4: 0x00850089 0x7f7c4eb0: 0x00000000 0x7f7c4eac: 0x06060606 0x7f7c4ea8: 0x06060606 0x7f7c4ea4: 0x06060606 0x7f7c4ea0: 0x06060606 0x7f7c4e9c: 0x00000000 0x7f7c4e98: 0x00000000 0x7f7c4e94: 0x06060606 0x7f7c4e90: 0x06060606 0x7f7c4e8c: 0x06060606 0x7f7c4e88: 0x06060606 0x7f7c4e84: 0x06060606 0x7f7c4e80: 0x06060606 0x7f7c4e7c: 0x06060606 0x7f7c4e78: 0x06060606 0x7f7c4e74: 0x06060606 0x7f7c4e70: 0x06060606 0x7f7c4e6c: 0x06060606 0x7f7c4e68: 0x06060606 0x7f7c4e64: 0x06060606 0x7f7c4e60: 0x06060606 <-esp