Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40271 )
Change subject: sb/intel: Factor out early_smbus.c for ICH7 and newer
......................................................................
Patch Set 2:
Patch Set 2:
Patch Set 2:
Patch Set 2:
So some devices have access to `smbus_write_byte()` now?
Some platforms will have that wrapper, yes. It was possible to write to SMBus before though, by directly using the smbus functions.
Yeah, I’d just mention it, when people look through the diff (some diffstat is smaller).
I plan on splitting this as requested by Nico anyway.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40271
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id16929cb9c25b8ec3bd067bf7d7605bce1fad2c5
Gerrit-Change-Number: 40271
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Christian Walter
christian.walter@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 09 Apr 2020 09:58:33 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment