Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35440 )
Change subject: intel/ibexpeak boards: Remove handled RCBA entries from replay
......................................................................
Patch Set 13: Code-Review+2
(2 comments)
https://review.coreboot.org/c/coreboot/+/35440/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/35440/1//COMMIT_MSG@9
PS1, Line 9: elsewhere
Where? […]
Ack
https://review.coreboot.org/c/coreboot/+/35440/11/src/mainboard/lenovo/x201/...
File src/mainboard/lenovo/x201/romstage.c:
https://review.coreboot.org/c/coreboot/+/35440/11/src/mainboard/lenovo/x201/...
PS11, Line 68: Must
When Intel says "must", I say "maybe not". I'm curious about those "performance counters", one day I'll try looking at them :)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35440
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I69fc8a5e16f7cf0e1068d0d2ed678a6c2f6e70a9
Gerrit-Change-Number: 35440
Gerrit-PatchSet: 13
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 05 Oct 2019 09:19:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment