Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35906 )
Change subject: mb/pcengines/apu2: use AGESA 1.0.0.4 with different AGESA.h headers
......................................................................
Patch Set 2:
Patch Set 2:
seems like the logic is backwards here, if you want to prevent those fields from being included when using the 1.0.04 binary
Exactly. We basically want to carve out the changes introduced in https://review.coreboot.org/c/coreboot/+/11225/
just for PC Engines apu2 platform.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35906
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3d85ee14e35dae8079e8d552b6530a3867f65876
Gerrit-Change-Number: 35906
Gerrit-PatchSet: 2
Gerrit-Owner: Piotr Kleinschmidt
piotr.kleinschmidt@3mdeb.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Piotr Kleinschmidt
piotr.kleinschmidt@3mdeb.com
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Matt DeVillier
matt.devillier@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 09 Oct 2019 17:20:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment