Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44253 )
Change subject: gpio: Pull down HiZ pins after reading tristate GPIO strapping ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44253/1/src/lib/gpio.c File src/lib/gpio.c:
https://review.coreboot.org/c/coreboot/+/44253/1/src/lib/gpio.c@117 PS1, Line 117: /* Disable pull to avoid wasting power. For HiZ we leave the : pull-down enabled, since letting them float freely back and : forth may waste power in the SoC's GPIO input logic. */
Different comment style matter?
This is correct "short form" coreboot style (the one below is the "long form").