5 Aug
2020
5 Aug
'20
8:30 a.m.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40946 )
Change subject: nb/intel/sandybridge/raminit: Add ECC debug code ......................................................................
Patch Set 3: Code-Review+1
(1 comment)
Other than that, LGTM
https://review.coreboot.org/c/coreboot/+/40946/3/src/northbridge/intel/sandy... File src/northbridge/intel/sandybridge/raminit.c:
https://review.coreboot.org/c/coreboot/+/40946/3/src/northbridge/intel/sandy... PS3, Line 436: * interleave are enabled, but there's no gurantee for it.
'gurantee' may be misspelled - perhaps 'guarantee'?
It is
--
To view, visit https://review.coreboot.org/c/coreboot/+/40946
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I76174ec962c9b0bb72852897586eb95d896d301e
Gerrit-Change-Number: 40946
Gerrit-PatchSet: 3
Gerrit-Owner: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-Comment-Date: Wed, 05 Aug 2020 08:30:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: build bot (Jenkins) no-reply@coreboot.org
Gerrit-MessageType: comment