[coreboot-gerrit] Change in coreboot[master]: mb/google/brya/var/craask: Disable LTE-related GPIOs based on fw_config

[Tyler Wang (Code Review)]

Attention is currently required from: Kangheui Won, Paul Menzel, Tim Wawrzynczak, Reka Norman, Nick Vaccaro.
Tyler Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63893 )

Change subject: mb/google/brya/var/craask: Disable LTE-related GPIOs based on fw_config
......................................................................

Patch Set 7:

(1 comment)

File src/mainboard/google/brya/variants/craask/fw_config.c:

https://review.coreboot.org/c/coreboot/+/63893/comment/02ac1f3e_40269622 
PS7, Line 23: 	if (!fw_config_probe(FW_CONFIG(DB_USB, DB_1C_LTE))) {
            : 		printk(BIOS_DEBUG, "Disable LTE-related GPIO pins.\n");
            : 		gpio_configure_pads(lte_disable_pads, ARRAY_SIZE(lte_disable_pads));
            : 	}
            :
> This approach leavess a gpio interrupt line (GPP_H19) floating for a short time. […]

Hi Nick,
I have 2 questions would like to discuss with you:
1. This approach leavess a gpio interrupt line (GPP_H19) floating for a short time.
> > We had set WWAN_RST_L to low and WWAN_EN to high in bootblock stage, but we didn't set interrupt pin. Is it the root cause of GPP_H19 be floating in a short time?

2. Override GPIO setting in gpio.c
> > Reference to Nivviks, seems like we don't need to override GPIO in ramstage for enable LTE module.

I will move disable LTE gpio settings to gpio.c as well.
Thanks!