Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36921 )
Change subject: soc/mediatek/mt8183: skip fast calibration for High frequency of TX RX window ......................................................................
Patch Set 3:
(1 comment)
please split into two patches:
1. soc/mediatek/mt8183: Correct clock rate settings
/* include the -4 and clock_rate * 64 */
2. soc/mediatek/mt8183: fully calibrate TX RX window on high frequency
/* include only the parts related to not doing calibration on those data */
https://review.coreboot.org/c/coreboot/+/36921/3/src/soc/mediatek/mt8183/dra... File src/soc/mediatek/mt8183/dramc_pi_calibration_api.c:
https://review.coreboot.org/c/coreboot/+/36921/3/src/soc/mediatek/mt8183/dra... PS3, Line 1591: freq_group Please add a comment here:
/* * The clock rate should be (memory frequency / 2 - 4), * and the 4MHz is introduced to reduce interference from * RF peripherals like modem, WiFi, and Bluetooth. */