Attention is currently required from: Jason Nien, Matt DeVillier, Martin Roth.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70900 )
Change subject: mb/google/skyrim: Add support for and select CONFIG_VBIOS_CACHE_IN_FMAP ......................................................................
Patch Set 8:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/70900/comment/3753035e_a418f071 PS1, Line 15:
We should add a depends_on here for a chromeos change to disable the saved psp_verstage. […]
The signed verstage has been removed from chromeos for now, so we can merge this when everything else is ready.
File src/mainboard/google/skyrim/Kconfig:
https://review.coreboot.org/c/coreboot/+/70900/comment/a6a79452_16df211e PS8, Line 108: VBIOS_CACHE_IN_FMAP Is there any reason we shouldn't just select this, since the cache region actually *is* in the FMAP after this change? if this isn't just saying that the FMAP has the VBIOS_CACHE region, maybe change this to USE_VBIOS_CACHE_IN_FMAP?