Attention is currently required from: Arthur Heymans, Caveh Jalali, Julius Werner, Subrata Banik.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80775?usp=email )
Change subject: Revert "lib: Explicitly declare heap as NOLOAD"
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Patchset:
PS1:
Haven't fully figured out what went wrong yet. The `memsz` in the program
header seems to lose the 1MiB heap, i.e. it's not allocated? Which seems wrong.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80775?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I8d49e2dc49cd2935a9d8023c989869ec9558039e
Gerrit-Change-Number: 80775
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Caveh Jalali
caveh@chromium.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Wed, 28 Feb 2024 14:37:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment