Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56070 )
Change subject: util/ifdtool: Add sklkbl to IFDv2 platforms
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
If anybody is motivated to rework ifdtool, it would be best to drop the IFDv1 and IFDv2 concept all together and make the different places in the code where the version is used aware of the chipset instead. In fact, there are "IFD v1.5" devices out there that need the IFD v1 code path on half of the code and the IFD v2 code path on the other half.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56070
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3f92b090e929336b5c18b442d1504ee1000f5594
Gerrit-Change-Number: 56070
Gerrit-PatchSet: 3
Gerrit-Owner: Jan Tatje
jan@jnt.io
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Thu, 08 Jul 2021 05:00:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment