Attention is currently required from: Mike Banon. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48424 )
Change subject: asus/a88xm-e: properly program the IRQ tables ......................................................................
Patch Set 1:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/48424/comment/160a5b15_c3eb721f PS1, Line 13: How did you determine the values? Just copying them from the Asus AM1I-A?
https://review.coreboot.org/c/coreboot/+/48424/comment/0d26ec08_33b10045 PS1, Line 15: * A88XM-E boots fine to Linux - no angry IRQ-related messages at dmesg; Can you please paste one of these messages in the git commit message?
Patchset:
PS1: Very nice.
File src/mainboard/asus/a88xm-e/mainboard.c:
https://review.coreboot.org/c/coreboot/+/48424/comment/e6ddcc2a_550d8301 PS1, Line 17: * This table defines the index into the picr/intr_data Please rewrap the comment to use 72 characters per line.