8 Aug
2019
8 Aug
'19
11:45 a.m.
Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34782 )
Change subject: mb/google/hatch: Refactor override_early_gpio_table ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34782/4/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/hatch/gpio.c:
https://review.coreboot.org/c/coreboot/+/34782/4/src/mainboard/google/hatch/... PS4, Line 56: PAD_CFG_GPI(GPP_F2, NONE, PLTRST),
I just realized. […]
I think we need configure memory strap pins correctly in the early_gpio_table.
--
To view, visit https://review.coreboot.org/c/coreboot/+/34782
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0552b08a284fd6fb41a09fef431a0d006b0cf0bd
Gerrit-Change-Number: 34782
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org
Gerrit-Reviewer: Peichao Li peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: Philip Chen philipchen@google.com
Gerrit-Reviewer: Shelley Chen shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 08 Aug 2019 09:45:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh furquan@google.com
Gerrit-MessageType: comment