build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25182 )
Change subject: smmstore: Add a key/val store facility in flash, mediated through SMM ......................................................................
Patch Set 12:
(5 comments)
https://review.coreboot.org/#/c/25182/12/src/drivers/smmstore/store.c File src/drivers/smmstore/store.c:
https://review.coreboot.org/#/c/25182/12/src/drivers/smmstore/store.c@180 PS12, Line 180: if (rdev_writeat(&store, &key_sz, end, 4) != 4) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/25182/12/src/drivers/smmstore/store.c@184 PS12, Line 184: if (rdev_writeat(&store, &value_sz, end, 4) != 4) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/25182/12/src/drivers/smmstore/store.c@188 PS12, Line 188: if (rdev_writeat(&store, key, end, key_sz) != key_sz) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/25182/12/src/drivers/smmstore/store.c@192 PS12, Line 192: if (rdev_writeat(&store, value, end, value_sz) != value_sz) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/25182/12/src/drivers/smmstore/store.c@197 PS12, Line 197: if (rdev_writeat(&store, &nul, end, 1) != 1) { braces {} are not necessary for single statement blocks