Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34770 )
Change subject: soc/mediatek: dsi: Unify format to bpp conversion
......................................................................
Patch Set 9:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34770/8/src/soc/mediatek/common/dsi...
File src/soc/mediatek/common/dsi.c:
https://review.coreboot.org/c/coreboot/+/34770/8/src/soc/mediatek/common/dsi...
PS8, Line 187: u32 bpp = mtk_dsi_get_bits_per_pixel(format);
nit: would probably be better to spell out this variable as bits_per_pixel as well to prevent any ch […]
Done
https://review.coreboot.org/c/coreboot/+/34770/8/src/soc/mediatek/mt8173/dsi...
File src/soc/mediatek/mt8173/dsi.c:
https://review.coreboot.org/c/coreboot/+/34770/8/src/soc/mediatek/mt8173/dsi...
PS8, Line 23: bpp
nit: would also keep this as bit(s)_per_pixel
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34770
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibd405220b73859e5592c68f498af07eef8d7edbc
Gerrit-Change-Number: 34770
Gerrit-PatchSet: 9
Gerrit-Owner: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Nicolas Boichat
drinkcat@chromium.org
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: jitao shi
jitao.shi@mediatek.com
Gerrit-Reviewer: yongqiang niu
yongqiang.niu@mediatek.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 10 Aug 2019 17:39:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment