Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37483 )
Change subject: mb/gigabyte/ga-h61m-s2pv: Add ga-h61m-ds2v as a variant ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37483/1/src/mainboard/gigabyte/ga-h... File src/mainboard/gigabyte/ga-h61m-s2pv/variants/ga-h61m-ds2v/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/37483/1/src/mainboard/gigabyte/ga-h... PS1, Line 75: irq 0xf0 = 0x08
We might be talking past each other: If the `superio.c` registers […]
I think I misread several things. So, if I understand correctly, the `io` lines must stay, because they are in `superio.c`.
However, was your original comment referring to these, or was it referring to the `irq` line instead?
https://review.coreboot.org/c/coreboot/+/37483/2/src/mainboard/gigabyte/ga-h... File src/mainboard/gigabyte/ga-h61m-s2pv/variants/ga-h61m-ds2v/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/37483/2/src/mainboard/gigabyte/ga-h... PS2, Line 23: 0x2
2 ? […]
If you want to refer a Gerrit change, you can use: CB:37849
That way, lazy people like me can click on it right away :P
But yes, I will change these numbers