[coreboot-gerrit] Change in coreboot[master]: soc/intel/cannonlake: Move GPIO PM configuration to soc level

[EricR Lai (Code Review)]

EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37685 )

Change subject: soc/intel/cannonlake: Move GPIO PM configuration to soc level
......................................................................

Patch Set 11:

(4 comments)

https://review.coreboot.org/c/coreboot/+/37685/6//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/37685/6//COMMIT_MSG@11 
PS6, Line 11:
> BUG=?

Done

https://review.coreboot.org/c/coreboot/+/37685/6/src/soc/intel/cannonlake/ac... 
File src/soc/intel/cannonlake/acpi/gpio.asl:

https://review.coreboot.org/c/coreboot/+/37685/6/src/soc/intel/cannonlake/ac... 
PS6, Line 162: Configure GPIO all Community Power Management
> nit: Configure Power Management bits for all GPIO communities?

Done

https://review.coreboot.org/c/coreboot/+/37685/6/src/soc/intel/cannonlake/ac... 
PS6, Line 166: GCPM
> I would like to change it. RGPM (restore GPIO PM) and EGPM (enable GPIO PM).

Done

https://review.coreboot.org/c/coreboot/+/37685/5/src/soc/intel/cannonlake/ac... 
File src/soc/intel/cannonlake/acpi/lpit.asl:

https://review.coreboot.org/c/coreboot/+/37685/5/src/soc/intel/cannonlake/ac... 
PS5, Line 79: /* Enable GPIO PM */
            : 				_SB.PCI0.LOCL (MISCCFG_ENABLE_GPIO_PM_CONFIG)
> the _DSM is only called when i run power_dbus_suspend.

Done