Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30987 )
Change subject: mb/asus: Add Asus A88XM-E FM2+ with documentation ......................................................................
Patch Set 47:
(3 comments)
https://review.coreboot.org/c/coreboot/+/30987/45/src/mainboard/asus/a88xm-e... File src/mainboard/asus/a88xm-e/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/30987/45/src/mainboard/asus/a88xm-e... PS45, Line 33: unused
But what is it? It is definitely unused if it's set to "off". I would replace with the device names.
Done.
https://review.coreboot.org/c/coreboot/+/30987/45/src/mainboard/asus/a88xm-e... PS45, Line 38: disabled
Please don't add redundant comments. One knows the device is disabled because it is "off". […]
Done.
https://review.coreboot.org/c/coreboot/+/30987/45/src/mainboard/asus/a88xm-e... PS45, Line 112: device pci 14.6 off end # unused : device pci 14.7 off end # unused : device pci 15.0 on end # PCIEX1_1 : device pci 15.1 off end # unused : device pci 15.2 on end # Onboard Ethernet : device pci 15.3 off end # unused
Which of these are PCIe root ports? You can use comments like this: […]
Done.