Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48083 )
Change subject: mb/supermicro/x11-lga1151-series: set mainboard_ops.init directly
......................................................................
Patch Set 5: Code-Review-1
(1 comment)
https://review.coreboot.org/c/coreboot/+/48083/5//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/48083/5//COMMIT_MSG@9
PS5, Line 9: Set mainboard_ops.init directly instead of using the indirection via a
: mainboard_enable function.
chip.init is run significantly earlier than dev.init, before resources are allocated. For the things you do, it might not be a problem but it's generally not a good idea to do init stuff before resource allocation.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48083
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I192e69a34fa262b38bc40a95fb11c22a4041d0ae
Gerrit-Change-Number: 48083
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 27 Nov 2020 18:42:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment