[coreboot-gerrit] [M] Change in coreboot[master]: soc/intel/common: Extend criteria to determine CSE firmware update

[Martin L Roth (Code Review)]

Attention is currently required from: Sridhar Siricilla.

Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46553?usp=email )

Change subject: soc/intel/common: Extend criteria to determine CSE firmware update
......................................................................

Patch Set 7:

(3 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/46553/comment/affe197d_af867cec :
PS7, Line 10: of exended criteria, coreboot checks for IFWI Build Version field besides
Please wrap the commit message to 72 characters.  This line looks like it's at 74 characters.

Patchset:

PS7: 
I'm assuming you plan on updating this since you restored it.  Tim and Furquan aren't as involved at coreboot as they used to be, so you might want to pick new reviewers for the patch.

File src/soc/intel/common/block/cse/cse_lite.c:

https://review.coreboot.org/c/coreboot/+/46553/comment/51d69e13_39ae46f8 :
PS7, Line 798: 		rv = cse_trigger_fw_update(cse_bp_info, &source_metadata, &target_rdev, cse_cbfs_rw, region_device_sz(&source_rdev));
> line over 96 characters

Please fix.