Jason Glenesk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43804 )
Change subject: /soc/amd/acpi: Move ACPI IVRS generation to coreboot
......................................................................
Patch Set 12:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43804/8/src/soc/amd/picasso/agesa_a...
File src/soc/amd/picasso/agesa_acpi.c:
https://review.coreboot.org/c/coreboot/+/43804/8/src/soc/amd/picasso/agesa_a...
PS8, Line 54: ivhd_ioapic->reserved = 0x0000;
Why not memset() the structure beforehand?
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43804
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I693f4399766c71c3ad53539634c65ba59afd0fe1
Gerrit-Change-Number: 43804
Gerrit-PatchSet: 12
Gerrit-Owner: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 14 Aug 2020 18:28:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment